-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AM/PM - 12 hour time picker #49
base: master
Are you sure you want to change the base?
Conversation
@radvansky-tomas I've updated my PR with code formatting and the couple of changes you made, I did notice that in your branch you reverted DateTimePickerWidget._changeMinuteSelection change which I think will now break when minutes are divided into intervals. |
@JamesMcIntosh I am not aware of any revert, I simply took latest version and added AM/PM like you did, for my personal project. If there are any bugs / missing parts...feel free to fix / change that. Once I see that is merged and stable enough I will switch back from my fork ;) |
Hi @dylanwuzh, just wondering if you are going to test/ review this pull request? I'm not actively using this library at the moment but and happy to finish getting this pull request merged into your source if you have any feedback. |
I don't know why such a feature isn't merged yet! I want it badly. |
@dylanwuzh LGTM :) |
Sorry guys bit busy and sick lately. Feel free you use my codes, as I said before I am not aware of any reverts I did during dev. So test it and let me know if it broke something. |
For me, I used this lite plugin for time selection until that pull request is merged and the plugin is updated. |
@dylanwuzh Are you going to merge this PR? |
Fixes issue #35
I have tested the code in
time_picker_widget.dart
I ported the code from
time_picker_widget.dart
across intodatetime_picker.dart