Make serde feature not depend on serde_derive #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look good! Thank you for the contribution. |
|
published as version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
ulidnot depend onserde_derivewith theserdefeature enabled, taking compilation with the feature enabled from5.98sto2.37s(ryzen 2600).Accommodations have been made for the places where the derive feature is used in doc tests (by adding
serde_deriveas a dev dependency), the drawback of this is serde_derive is compiled unconditionally under any modes that make use of dev-dependencies (optional dev dependencies is not a thing, but if someone who knows more can figure it out that would be appreciated), but I believe the benefit of not compilingserde_derivefor normal users of the crate (when they don't need it to run the serde related library code) is worthwhile.This change has been made possible by the implicit coupling of serde and serde_derive versions (without using the "derive" feature) that was introduced in
serde 1.0.186