Add compress and uncompress utility methods #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add basic constants of zlib. - Add conditions to replace numeric code errors. - Add the utility methods 'zlib-compress' and 'zlib-uncompress'. - Use 'compress2' binding method of zlib to pass compression level. - Add basic test of compress/decompress.
waywardmonkeys
requested changes
Oct 9, 2024
There was a problem hiding this comment.
This shouldn't be using strings / c-strings / etc in this way but rather something like what I did in the leveldb bindings: https://github.com/dylan-foundry/leveldb-dylan
Using byte-storage-address will work for a couple of types, I don't recall the full details at the moment.
But at any rate, the byte data shouldn't be stored into regular strings.
|
(If you need help with how to do that stuff, let me me know here or elsewhere and I'll find the time to help you figure it out.) |
|
Thank you for your support. I'll read leveldb-dylan and ask you for help later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility methods compress, uncompress and documentation.