Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rating step to 0.5 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yberdnikov
Copy link

Changed rating step to 0.5, so user can rate using half-star,
for example 2.5 stars.

Changed rating step to 0.5, so user can rate using half-star,
for example 2.5 stars.
@dyang
Copy link
Owner

dyang commented Mar 18, 2013

Hi Yuriy, thanks for the patch! I think the proposed feature is fine. I'd like to keep the feature, but meanwhile turn it off by default and only turn it on (probably through setting a property) if a developer chooses to. The reason is to avoid confusing end users when they want to rate something like 2 only to find 1.5 gets displayed. Do you think this makes sense?

@yberdnikov
Copy link
Author

Sure, I'll rewrite code to be more configurable.

2013/3/18 Derek Yang [email protected]

Hi Yuriy, thanks for the patch! I think the proposed feature is fine. I'd
like to keep the feature, but meanwhile turn it off by default and only
turn it on (probably through setting a property) if a developer chooses to.
The reason is to avoid confusing end users when they want to rate something
like 2 only to find 1.5 gets displayed. Do you think this makes sense?


Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-15045581
.

@iconmamobility
Copy link

how to select half star?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants