Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of dynamic properties for PHP8.2 #28

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

patdel0
Copy link
Contributor

@patdel0 patdel0 commented Jun 27, 2024

  • Version number has been bumped

PHP 8.2 has introduced stricter rules regarding dynamic properties in classes.
Previously, this component used dynamic properties, which are no longer supported in PHP 8.2.
As a result, sites using this plugin were encountering deprecation errors when they upgraded to PHP 8.2.

image

How to Test

  1. Clone and run the latest version of Bikeshed
  2. Install Query Monitor (for some reason I'm unable to see the deprecation warnings in my docker logs)
  3. Activate the dxw members only plugin
  4. Confirm the deprecation warnings are occurring
  5. Navigate to wp-content/plugins/dxw-members-only and checkout this branch
  6. Confirm the deprecation warnings are no longer present

Copy link
Contributor

@jkeasley jkeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as described

@patdel0 patdel0 merged commit 88591d9 into master Jun 27, 2024
3 checks passed
@patdel0 patdel0 deleted the fix/deprecation-for-php8.2-compatability branch June 27, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants