Update composer to create an installable set on modern instances #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snim2
requested changes
Oct 18, 2023
|
yep, done 👍 |
snim2
approved these changes
Oct 18, 2023
This commit updates the composer file to set the platform to be php 7.4.3 to allow the package set to be installed on modern machines running recent versions of php (eg php 8.2) to test: download the code locally and ensure that composer install completes as expected.
jkeasley
force-pushed
the
chore/update-composer-to-installable-set
branch
from
168bc75
to
c767716
Compare
|
@snim2 I just realised that the _vendor dir is in this repo and changes needed from that needed to be added, so this probably needs re-reviewing? |
This commit updates the plugin to use vendor.phar for its composer dependencies, rather than the _vendor directory to Test: in a local WP instance install this plugin and confirm that the plugin operates as expected.
jkeasley
force-pushed
the
chore/update-composer-to-installable-set
branch
from
d41e06c
to
e7f5ef2
Compare
RobjS
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the composer file to set the platform to be php 7.4.3 to allow the package set to be installed on modern machines running recent versions of php (eg php 8.2)
to test:
download the code locally and ensure that composer install completes as expected.