Update map UI #141
Merged
Update map UI #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This style was inadvertently removed in a previous commit.
Controls are now on the left and the DAQI scale is on the right
Previously we were calculating these from the bounds, but they were a bit off. By specifying them explicitly we have more control and it decouples the two tasks of adding zone boundaries to the map and adding zone labels to the map.
This method allows us to fetch the latest forecast for all zones at once, which we will want to do when displaying forecast data on the map.
This endpoint allows the map to fetch pollution data to display.
Rather than create the zone labels together with the zone boundaries, we now split these two processes up so that markers can be updated on each refresh using data from the API.
How was it even working in production before??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR updates the map's UI to show pollution scores along with zone labels. This required adding a new API endpoint
/pollutant_forecaststo provide the values to the map.Trello: https://trello.com/c/uLIXdskr/131-show-aq-index-on-the-map-in-place-of-the-labels-see-figma
Screenshots of UI changes
Before
After