Handle invalid parameter values #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can move the repeated allow statement to the before block to DRY up the test.
Previously we were throwing an error here. Now we catch it and default to today's date.
Previously we were throwing an error here. Now we default to today instead.
Previously the value would be passed to the map unchanged and cause problems there. Now we default to total pollution instead.
jdudley1123
force-pushed
the
error-handling-2
branch
from
d02af66
to
17c0cec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously invalid parameter values for date, day, and pollutant would cause errors.
Changes in this PR
This PR adds error handling with fallbacks for date, day, and pollution. Date and day fallback to today, pollution falls back to 'Total' (ie all pollution).