Store pollutant and map coordinates and zoom in URL #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer have multiple pollution layers or a control to switch between them, so this code is unnecessary (and currently throws an error).
These two controllers have very similar functionality and are both very small, so it makes sense to combine them. I've also cleaned up a few leftover attributes that we're no longer using.
The prediction controller doesn't just focus on predictions anymore, so it makes sense to generalise its name.
Storing the pollutant in the URL means we can persist it and include it in links that are shared. It behaves like the zone selector.
Storing the map coordinates and zoom in the URL means we can persist them and include them in links that are shared.
jdudley1123
force-pushed
the
url-params-3
branch
from
86e46dd to
19f1cfa
Compare
Currently we store the day ('today', 'tomorrow', etc.) in the URL. If the user shares the tomorrow URL on Monday and the recipient clicks on Tuesday, they will see the forecast for Wednesday.
This change means we store the date ('2024-11-20') instead. If the date is outside of the bounds of the three day forecast, we fall back to the nearest day (so today for past dates and day after tomorrow for future dates).
The former URLs with day will still work, but date takes precedence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we store the day and the zone in the URL, allowing them to be persisted. However, we don't store the pollutant or map settings, so they can't be persisted or included in shared URLs.
Changes in this PR
This PR: