Drive page content with URL parameters #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The day parameter in the URL is used to select the day forecast and to style the tab components. The classes still refer to the active tab as 'today', but we'll clean that up later.
Currently the map loads to today's map. We need it to check which day and pollution state it's rendering when it loads.
Changing the frame will mean we lose the map, so we need to reinitialize it on connection.
Because the form is within the Turbo frame, only the frame will be affected, and will load a new forecast with the updated parameters from the form.
Now we're using a single Turbo frame for the forecast, map, and predictions, we can get rid of the old frames and streaming.
Following the same pattern we established for the zone selector, we remove the link from each tab and instead add a hidden form field and submit the form when a tab is clicked on.
jdudley1123
force-pushed
the
url-params-3
branch
from
cb5a402
to
80c92f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently switching zone or day involves a lot of JS and passing of variables. The forecast (the tabs), the map, and the predictions (UV, pollen, temperature) are all handled separately which makes the logic complex.
Changes in this PR
This PR changes the page content to be driven by the URL parameters
zoneandday. The existing Turbo frames/stream are replaced by a single Turbo frame for the whole forecast + map + predictions block, which is updated by a form containing the zone and day information.This has the added benefit that shared URLs can be more specific.