Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #115

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Cleanup #115

merged 3 commits into from
Nov 18, 2024

Conversation

jdudley1123
Copy link
Member

Changes in this PR

This PR does some cleanup:

  • Fixes some broken JavaScript
  • Moves some content from one partial to another (with no effect on presentation)
  • Changes the zone dropdown to a native HTML select element

Screenshots of UI changes

Before

image

After

image

@jdudley1123
Fix day select
d15637c 
Somehow this got broken, we should really add some tests for it
@jdudley1123
Move header out of location partial
e06c7b4 
The header is unrelated to the location selector, so it shouldn't be there.
@jdudley1123
Use native select element for zone selector
b8c918e 
Using the native HTML element saves us a load of overhead and is more accessible.
@jdudley1123 jdudley1123 merged commit 6a6a5be into develop Nov 18, 2024
2 checks passed
@jdudley1123 jdudley1123 deleted the cleanup-1 branch November 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdudley1123