Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split street map into two layers with custom styles #109

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

jdudley1123
Copy link
Member

@jdudley1123 jdudley1123 commented Nov 15, 2024

Context

The current map is quite hard to read because the pollution layer is over the top of the place names.

Changes in this PR

This PR replaces the stock map styles with two custom styles applied as two separate layers. The first shows the streets and water, and goes under the pollution layer. The second shows place names and goes on top of the pollution layer. This approach makes the map much more readable.

The appearance of these styles can be managed at https://cloud.maptiler.com/maps/

Trello: https://trello.com/c/dKiwJnEI/106-spike-to-understand-optimal-map-layering-styling-and-transparency

Screenshots of UI changes

Before

image

After

image

Next steps

We replace the stock map styles with two custom styles applied as two separate layers. The first shows the streets and water, and goes under the pollution layer. The second shows place names and goes on top of the pollution layer.

This approach makes the map much more readable.

The appearance of these styles can be managed at https://cloud.maptiler.com/maps/
Copy link
Contributor

@patrickjfl patrickjfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is much more readable, although I guess at some point we will also need to do some work around duplication of labels in different layers...

@jdudley1123
Copy link
Member Author

Agree this is much more readable, although I guess at some point we will also need to do some work around duplication of labels in different layers...

There's no duplication between the two map layers. There is a little bit of duplication where zone names are the same as labels on the map, but that's unavoidable.

@jdudley1123 jdudley1123 merged commit c0f1be0 into develop Nov 15, 2024
2 checks passed
@jdudley1123 jdudley1123 deleted the map-styles branch November 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants