Add ability to search on map #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdudley1123
force-pushed
the
search-on-map
branch
from
26fbbb7 to
671c234
Compare
jdudley1123
force-pushed
the
search-on-map
branch
from
671c234 to
ecd813d
Compare
patrickjfl
approved these changes
Nov 15, 2024
| .maptilerGeocoding({ | ||
| apiKey: this.settings.maptilerApiKey, | ||
| country: ["GB"], | ||
| proximity: [-0.116773, 51.510357], // Big Ben, lng lat |
This will allow us to use it in other methods.
This uses Maptiler's Geocoding control, and all the behaviour and styling is handled by Maptiler. Search is restricted to the UK. We could restrict further to roughly Airtext's coverage, but that requires more complex bounding boxes. Instead I've used the proximity setting to make it prefer results that are near London.
jdudley1123
force-pushed
the
search-on-map
branch
from
ecd813d to
3ee858e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The user should be able to search for locations on the map so that they can quickly navigate to places that matter to them.
To do this we need a geocoder, which translates a natural language location like 'Barnet' or 'St Paul's Cathedral' into coordinates. Maptiler provides a geocoder which we can use for this.
Trello: https://trello.com/c/ng2eT8cY/112-allow-user-to-search-for-locations-on-the-map
Changes in this PR
This PR adds Maptiler's standard search control which uses their geocoder. All the behaviour and styling is handled by Maptiler.
Search is restricted to the UK. We could restrict further to roughly Airtext's coverage, but that requires more complex bounding boxes.
Screenshots of UI changes
Before
After