Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Fix CI and adding Plausible script #507

Merged
merged 18 commits into from
Aug 15, 2024
Merged

[PR] Fix CI and adding Plausible script #507

merged 18 commits into from
Aug 15, 2024

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Aug 14, 2024 •
edited
Loading

closes #505
closes #506

Fixes warnings.

@LuchoTurtle LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person chore a tedious but necessary task often paying technical debt labels Aug 14, 2024
@LuchoTurtle LuchoTurtle self-assigned this Aug 14, 2024
@LuchoTurtle LuchoTurtle changed the title [PR] Fix CI [PR] Fix CI and adding Plausible script Aug 14, 2024
@LuchoTurtle
Copy link
Member Author

LuchoTurtle commented Aug 14, 2024 •
edited
Loading

@nelsonic https://github.com/dwyl/dwyl-site/actions/runs/10389902639/job/28769062607?pr=507

Plenty of errors that the Validator finds. Am I meant to fix these? Are they even HTML5 files?

@LuchoTurtle
Copy link
Member Author

Went ahead and fixed all the warnings.

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Aug 14, 2024
@LuchoTurtle LuchoTurtle requested a review from nelsonic August 14, 2024 16:21
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Aug 14, 2024
nelsonic
nelsonic approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the HTML and updating the Analytics URL. 👌

@nelsonic nelsonic merged commit 61c967a into main Aug 15, 2024
1 check passed
@nelsonic nelsonic deleted the ci-fix branch August 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Plausible Analytics with analytics.dwyl.com GitHub Actions CI Failing
2 participants
@LuchoTurtle @nelsonic