Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs fixes #481

Merged
merged 3 commits into from
Nov 26, 2018
Merged

bugs fixes #481

merged 3 commits into from
Nov 26, 2018

Conversation

RobStallion
Copy link
Member

@RobStallion RobStallion commented Nov 6, 2018

ensures user_msg_read and other_type are created in database when user is created #475
allows messages to users to be formatted #477

@RobStallion RobStallion self-assigned this Nov 6, 2018
@RobStallion RobStallion changed the base branch from master to sprint-8 November 6, 2018 15:12
@RobStallion
Copy link
Member Author

I am not sure what is causing the build to fail at the moment. I cannot see anything that would have caused this to fail. Branches that were working previously are now also failing (see here) which leads me to believe that the issue could be to do with travis.

The error message we are getting is

     ** (Bamboo.SMTPAdapter.SMTPError) There was a problem sending the email through SMTP.
     
     The error is :retries_exceeded
     
     More detail below:
     
     {:network_failure, "[secure]", {:error, :timeout}}

The error seems to be coming from this module. I have opened an issue here to see if anyone can help shine a light on what could be causing the issue.

@SimonLab
Copy link
Member

My guess is that Travis doesn't support smtp request to mailgun, see https://docs.travis-ci.com/user/common-build-problems/#ftpsmtpother-protocol-does-not-work

We could try to use a http request, I think mailgun support allow this via its API

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #481 into sprint-8 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           sprint-8     #481      +/-   ##
============================================
- Coverage     98.22%   98.22%   -0.01%     
============================================
  Files            28       29       +1     
  Lines           563      562       -1     
============================================
- Hits            553      552       -1     
  Misses           10       10
Impacted Files Coverage Δ
web/controllers/user_controller.ex 100% <100%> (ø) ⬆️
web/controllers/password_controller.ex 100% <100%> (ø) ⬆️
lib/bep/mock/mailer.ex 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f81327...0576a05. Read the comment docs.

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @RobStallion 👍

@SimonLab SimonLab merged commit b7841a8 into sprint-8 Nov 26, 2018
@SimonLab SimonLab deleted the sprint-8-bugs branch November 26, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants