Gracefully shutting down the AmazonsS3 ExecutorService #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd timeout before issuing shutdownNow
|
@dwhjames this looks good. Can someone please merge? |
|
Is this still actively maintained? @dwhjames |
|
@bluesockets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Here is a PR that will gracefully shuts down the S3 ExecutorService. Currently the shutdown() method issues a shutdownNow() that interrupts the com.amazonaws.http.IdleConnectionReaper causing it to throw an java.lang.InterruptedException. Issuing a shutdown() with a 30 second timeout gets rid of the exception, and allows some time for the client to spin down.
Thanks for your work on
aws-wrap