Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-14233): Update pull-test-results/modify to remove snowball SQS pattern #88

Merged
merged 9 commits into from
Nov 1, 2024

Conversation

m-mullen
Copy link
Contributor

@m-mullen m-mullen commented Oct 24, 2024

Update pull-test-results/modify to remove snowball SQS pattern

Update pull-test-results/modify to remove snowball SQS pattern
CB2-14233

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

@m-mullen m-mullen marked this pull request as ready for review October 24, 2024 14:03
src/insert.ts Show resolved Hide resolved
@Daniel-Searle Daniel-Searle self-requested a review October 25, 2024 10:47
@cb-cs
Copy link
Contributor

cb-cs commented Oct 29, 2024

Code looks good but there is no coverage for the 2 lines below in the eventHandler catch block, can these be added please. Happy to approve then.

console.error(error);
batchItemFailures.push({ itemIdentifier: record.messageId });

@m-coslett m-coslett merged commit 447df92 into develop Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants