-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any model architecture #3
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # locoprop/trainer.py
Works well. example notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Ideally we would update at least the test/autoencoder.py
example (and the README) for future reference.
I've left some comments where I didn't quite understand.
Another thing I've noticed yesterday is that torch.autograd.grad
doesn't work with integer tensors as inputs, which happens e.g. when using nn.Embedding
. Not sure if this is easily resolvable, so we don't need to address it now. But something to keep in mind for the future.
While training seems to work with Lightning, the standard training loop breaks for some reason: https://colab.research.google.com/drive/1hNLavl5jYgf7-DxfmnTucyCAcMHS4y4c?usp=sharing Don't really know what's going on, the only difference is the training loop AFAICT. |
We get roughly the same convergence with an outer learning rate of 0.01. Look at this copy of your notebook. |
No description provided.