Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot is not attached when testing outline scenarios. #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceniy
Copy link

@ceniy ceniy commented Feb 24, 2021

  1. When outline scenarios are executed, the ScenarioTested::BEFORE and ScenarioTested::AFTER are not triggered. So I added ExampleTested::BEFORE and ExampleTested::AFTER in the event list.
  2. Removed the codes in onAfterOutlineTested as the count will be added inside onAfterScenarioTested

@PurHur
Copy link
Collaborator

PurHur commented Feb 24, 2021

Looks good for me but we should wait some time.

@PurHur
Copy link
Collaborator

PurHur commented Feb 24, 2021

I checked the constants. Looks good but i cant test it now. Do you think this will break anything? If not i will merge it.

@ceniy
Copy link
Author

ceniy commented Feb 24, 2021

I tested in my local with outline scenarios and normal scenarios. They work fine. The count of the passed and failed scenarios are correct. Furthermore screenshots are attached in the correct place.

@PurHur
Copy link
Collaborator

PurHur commented Feb 24, 2021

Then thank you for your contribution. Everything helps :)

@PurHur
Copy link
Collaborator

PurHur commented Feb 24, 2021

Hmm i will look into it. But i have to setup my pipeline again. If anybody is intrested in something automated go for it.

@kalkin
Copy link

kalkin commented Jul 19, 2021

So what is the state of this PR?

@PurHur
Copy link
Collaborator

PurHur commented Nov 3, 2021

@kalkin I think this PR will break stuff.
Are you interested in working on the project? We actually need a github action pipeline to test this package itself. Quiet an interesting project.

@PurHur
Copy link
Collaborator

PurHur commented Dec 12, 2023

@kalkin is this PR still important to you?

I will be more active in the next time and i will check your PR as well again if it breaks stuff or not else i will merge all the things to the current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants