Skip to content

Commit

Permalink
manifests: fedora-coreos-base: temporary support for RSA-SHA1 keys on…
Browse files Browse the repository at this point in the history
… f33

For F33 let's re-enable RSA-SHA1 keys for now so our kola tests will
work. The plan is to only re-enable this briefly while we wait for
an upstream feature [1] to be implemented. We had moved to an ecdsa
key [2] but AWS doesn't support non RSA keys [3] so we reverted it
for now in [4].

[1] golang/go#37278 (comment)
[2] coreos/coreos-assembler#1749
[3] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html#how-to-generate-your-own-key-and-import-it-to-aws
[4] coreos/coreos-assembler#1767
  • Loading branch information
dustymabe committed Oct 6, 2020
1 parent cab3d07 commit be947c2
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions manifests/fedora-coreos-base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,27 @@ postprocess:
chmod 755 /usr/libexec/coreos-chrony-helper
chmod 755 /usr/lib/systemd/system-generators/coreos-platform-chrony
# For F33 let's re-enable RSA-SHA1 keys for now so our kola tests will
# work. The plan is to only re-enable this briefly while we wait for
# an upstream feature [1] to be implemented. We had moved to an ecdsa
# key [2] but AWS doesn't support non RSA keys [3] so we reverted it
# for now in [4].
#
# [1] https://github.com/golang/go/issues/37278#issuecomment-704287991
# [2] https://github.com/coreos/coreos-assembler/pull/1749
# [3] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html#how-to-generate-your-own-key-and-import-it-to-aws
# [4] https://github.com/coreos/coreos-assembler/pull/1767
- |
#!/usr/bin/env bash
source /etc/os-release
if [ "$VERSION_ID" != "32" ]; then
cat > /etc/ssh/sshd_config.d/10-fcos-insecure-rsa-key.conf <<EOF
# For now allow RSA-SHA1 keys.
# https://github.com/coreos/coreos-assembler/issues/1772
PubkeyAcceptedKeyTypes=+ssh-rsa
EOF
fi
packages:
# Security
- selinux-policy-targeted
Expand Down

0 comments on commit be947c2

Please sign in to comment.