money notation #95
money notation #95
Conversation
Signed-off-by: Leonardo <[email protected]>
Signed-off-by: Leonardo <[email protected]>
.gitignore
Outdated
| # Test binary, built with `go test -c` | ||
| *.test | ||
|
|
||
| # Output of the go coverage tool, specifically when used with LiteIDE | ||
| *.out |
There was a problem hiding this comment.
My own two cents:
If you need to ignore something that is specific to a project it belongs in the project's .gitignore
If you need to ignore something that is specific to the developer it belongs in the developer's global .gitignore.
Thoughts?
There was a problem hiding this comment.
I'll remove the .gitignore from the PR
| "fmt" | ||
| ) | ||
|
|
||
| func Finance(f float64) string { |
There was a problem hiding this comment.
I wonder if it would make sense to take some optional Options which could set things like which $ sign to use and if it should be prepended or appended (or omitted entirely) and could control the # of decimal points.
So you could do things like:
1.83M USD€2.34T48.9945
etc. Could also look at the various locales used with https://www.php.net/manual/en/function.money-format.php
There was a problem hiding this comment.
Very good idea, I'll add the Options pattern, the options will be:
- WithSign(s string) // can pass "" to remove the default ($) sign
- WithAppend() // if no append, Prepend is default -- otherwise could add both options
- WithPrecision(n int) // defaults to .2
WDYT?
This reverts commit 8e799e8.
Signed-off-by: Leonardo Faoro <[email protected]>
fixes #94
I had to add a .gitignore file as the editor .idea/.vscode directories were being picked up. Took the liberty to add the other standard golang gitignore entries as well, hope you don't mind.