Add precision and round functions #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdey
reviewed
Apr 24, 2020
Comment on lines
+78
to
+79
| f := fmt.Sprintf("%%.%df", precision) | ||
| res := fmt.Sprintf(f, val) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Dustin.
I like your lib go-humanize. And I want to suggest some improvements.
This changes will allow me to use this library to manage size disk correctly. When we work with bytes to manage size disk we face to some problems with rounding values. For example, if you want to create a disk partition you have to see how much free space disk have. So, if we ask to create 1GB partition however we have 999.99 MB we got an error.
For these cases, I offer to add precision and different rounding functions.
These changes don’t affect for main library functional and maintain compatibility with previous version your lib.
Please, review this code.
With hope to your approvement, Tony.