Comma() is 2.5 faster now #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
suggested changes
Mar 20, 2024
done! Co-authored-by: Olivier Mengué <[email protected]>
|
I think that #120 should be merged first. Not because I wrote it, but because it adds automated tests that will give more confidence in the impact of the changes here. |
|
sure @dolmen, it waited 2 years and can wait a bit longer. Hope your PR will be merged soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Decided to leetcode
Comma(). The result is in this PR. Managed to get rid of 4 allocations, removed 2 dependencies and reduced the execution time.