explorer: fix owner key in provisioner page #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDauven
previously approved these changes
Jan 3, 2025
ascartabelli
reviewed
Jan 4, 2025
There was a problem hiding this comment.
Left a suggestion about the code.
Seems this will resolve #3305 so the commit message should account for that.
You need to update the snapshots afterwards: @kieranhall or @nortonandreev can you help @herr-seppia here?
explorer/src/lib/components/provisioners-list/ProvisionersList.svelte
Outdated
Show resolved
Hide resolved
herr-seppia
force-pushed
the
fix-owner-provisioners
branch
from
331a886 to
3df8dad
Compare
No need for that, since your snapshot doesn't include provisioners with key split |
ascartabelli
approved these changes
Jan 4, 2025
Ok no need for that now with the code change: I'll make a note about adding provisioners of a different type to cover the other case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.