Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Change password setting as enabled by default #3288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Dec 23, 2024

Resolves #3287

@nortonandreev
Copy link
Contributor

Screenshot 2024-12-23 at 16 24 11

If so, let's update this saying that Setting a password is recommended.
Update the copy to something that explains why setting a password is more secure rather than using the mnemonic – as this is the opposite of what the current copy suggests.

If the user disables the Password option, we can display a warning banner instead, outlining the risks of not setting a password.

@nortonandreev
Copy link
Contributor

I think we can get rid of the Please store your password safely. paragraph.

also, check if you want to enforce the minimum length of 8 characters, or ditch any requirements, as Thomas suggested.

I would still consult with @ZER0 first, as there has been quite a lot of discussions around this flow and personally don't want to proceed unless we hear from him too.

@HDauven HDauven force-pushed the 3287/show-password-as-default branch from 9666d30 to 3ae2329 Compare December 23, 2024 15:13
@nortonandreev nortonandreev requested a review from ZER0 December 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet: Make setting the password the default
2 participants