Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: Add dusk-vm #3237

Merged
merged 12 commits into from
Dec 22, 2024
Merged

vm: Add dusk-vm #3237

merged 12 commits into from
Dec 22, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 19, 2024

To help reviewing these changes, I've split up the work into this one and:

Resolves #3235

@moCello moCello mentioned this pull request Dec 20, 2024
2 tasks
@moCello moCello marked this pull request as draft December 20, 2024 13:15
@moCello moCello marked this pull request as ready for review December 20, 2024 15:54
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vm/src/lib.rs Show resolved Hide resolved
vm/src/cache.rs Show resolved Hide resolved
vm/rustfmt.toml Show resolved Hide resolved
@moCello moCello mentioned this pull request Dec 22, 2024
5 tasks
@moCello
Copy link
Member Author

moCello commented Dec 22, 2024

@herr-seppia good finds! I've created #3273 to pick up your comments at a later point!

@moCello moCello merged commit 3b60ac2 into master Dec 22, 2024
32 checks passed
@moCello moCello deleted the mocello/3235_vm branch December 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vm: Add a dusk-vm workspace member
4 participants