Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Fix wrong error shown in the login screen #3232

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ascartabelli
Copy link
Contributor

@ascartabelli ascartabelli commented Dec 19, 2024

Resolves #3226
Resolves #3097

@ascartabelli ascartabelli self-assigned this Dec 19, 2024
@ascartabelli ascartabelli force-pushed the feature-3226 branch 3 times, most recently from f2d2d7d to 4f24911 Compare December 19, 2024 10:55
@ascartabelli ascartabelli marked this pull request as ready for review December 19, 2024 10:56
@nortonandreev
Copy link
Contributor

Was wondering if we should instead have this PR resolve this issue: #3097

Perhaps with the addition of an error if it cannot connect to the Network.

I don't think that the PR solves the core issues that have been outlined in #3226.

@ascartabelli
Copy link
Contributor Author

ascartabelli commented Dec 19, 2024

I completely forgot we already had #3097 , I'll update the commit message tomorrow morning so that I include that as well.
Although I do think that this addresses one of the issues raised in #3226, the main one: the other ones are the same as #3227 and #3228 (which I consider as duplicates, and the core issue still needs to be investigated.

Another issue raised by the ones opened by @voidsculptorart , the one we talked about today, is the one about the proper loading of the protocol driver as we do have a bug about a case not handled with a graceful error message.
For this one I'll open a new issue.

@nortonandreev
Copy link
Contributor

Screenshot 2024-12-19 at 22 44 57

Type error looks odd – but I guess it's not on our side. 🥴 Still better to what we had!

nortonandreev
nortonandreev previously approved these changes Dec 19, 2024
@ascartabelli ascartabelli merged commit 379af86 into master Dec 20, 2024
16 checks passed
@ascartabelli ascartabelli deleted the feature-3226 branch December 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants