Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: open session using prev_state_root #3194

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

herr-seppia
Copy link
Member

No description provided.

fed-franz
fed-franz previously approved these changes Dec 17, 2024
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia
Copy link
Member Author

@fed-franz I'm currently waiting because I've a doubt.

I'm not sure we should enforce the prev_state_root in the accept, maybe it's better to use the rusk tip

Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 567c280 into master Dec 19, 2024
16 checks passed
@herr-seppia herr-seppia deleted the verify_state_root branch December 19, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants