node-data: change transaction hash method to digest #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neotamandua
requested review from
fed-franz,
HDauven,
moCello and
herr-seppia
herr-seppia
requested changes
Dec 20, 2024
There was a problem hiding this comment.
I'm not sure about the rename everywhere to fault_digests
The only part where the digest is used is in the merkletree (like we do for txs)
For the rest (like checking if a fault is already present in the db) we should use fault_id
Anyway, this is just a "conservative" rfc, I'll go deeper through a detailed review asap
Neotamandua
force-pushed
the
neotamandua/tx_digest
branch
from
54420f3 to
9296952
Compare
Neotamandua
force-pushed
the
neotamandua/tx_digest
branch
from
9296952 to
02c44e9
Compare
Neotamandua
force-pushed
the
neotamandua/tx_digest
branch
from
02c44e9 to
b480d9a
Compare
herr-seppia
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3014