rusk-wallet: Add method to store last block height in cache #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daksh14
force-pushed
the
rusk-wallet-block-height-show
branch
from
3ed82f6 to
5ad4485
Compare
|
When syncing I seem to be getting this error: The sync seems to work fine, and it finishes. Afterwards, I can make transactions with no problem. Not sure if it is a false-positive or something else |
Daksh14
force-pushed
the
rusk-wallet-block-height-show
branch
from
d9e2dd7 to
f719d96
Compare
moCello
reviewed
Oct 11, 2024
moCello
reviewed
Oct 11, 2024
moCello
reviewed
Oct 11, 2024
Daksh14
force-pushed
the
rusk-wallet-block-height-show
branch
from
7b76a30 to
e0e979f
Compare
Add sync status enum to display correct sync status to user and current synced block height from the cache Handle channel TryRecv Error
Daksh14
force-pushed
the
rusk-wallet-block-height-show
branch
from
1d26d36 to
b03f31b
Compare
|
@Daksh14 the current behavior I see is that the block height is only increased when a note is inserted. I think this will be extremely misleading for users when they compare the block height in the wallet with the block height on the explorer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sync status enum to display correct sync status to user and current synced block height from the cache
Closes #2501
Screenshots:
Also closes #2567