Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk-wallet: Add is_sycned() function call to estimate sync completion #2540

Merged
merged 9 commits into from
Oct 1, 2024
Merged

rusk-wallet: Add is_sycned() function call to estimate sync completion #2540

merged 9 commits into from
Oct 1, 2024

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Sep 30, 2024 •
edited
Loading

  • Check if the db is synced with the network
  • If not display placeholder on balance and don't allow wallet operations

Closes #2488

@Daksh14 Daksh14 changed the title rusk-wallet: Add is_sycned() function call to display balance placeho… rusk-wallet: Add is_sycned() function call to estimate sync completion Sep 30, 2024
moCello
moCello reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy doesn't pass yet, and I've also added some other comments

rusk-wallet/src/bin/interactive.rs Show resolved Hide resolved
rusk-wallet/src/bin/interactive.rs Outdated Show resolved Hide resolved
rusk-wallet/src/clients.rs Outdated Show resolved Hide resolved
rusk-wallet/src/wallet.rs Outdated Show resolved Hide resolved
xevisalle
xevisalle previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm given that we need to merge this asap. There are minor things that would like to tackle soon. Also, haven't checked @moCello comments, if they haven't been addressed please merge now but open an issue to address them later.

rusk-wallet/src/wallet/gas.rs Outdated Show resolved Hide resolved
moCello
moCello previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments aren't fully addresses and there is much more in this PR than is it's scope. But I'll approve so that we can ship the fixes quickly.

@Daksh14 Daksh14 dismissed stale reviews from moCello and xevisalle via 56370d8 October 1, 2024 19:13
@xevisalle xevisalle self-requested a review October 1, 2024 20:19
xevisalle
xevisalle approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since the fixes need to be merged asap

@Daksh14 Daksh14 merged commit 30b0f38 into master Oct 1, 2024
11 checks passed
@Daksh14 Daksh14 deleted the fix-wrong-balance branch October 1, 2024 20:22
This was referenced Oct 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xevisalle xevisalle xevisalle approved these changes

@moCello moCello moCello left review comments

@HDauven HDauven Awaiting requested review from HDauven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rusk-wallet: fix incorrect balances
3 participants
@Daksh14 @xevisalle @moCello