Add conversions between Moonlight and Phoenix to wallet-core and test them
#2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
requested review from
ZER0,
fed-franz,
HDauven,
Daksh14,
moCello,
herr-seppia and
Neotamandua
ureeves
force-pushed
the
wallet-convert
branch
from
cee1a3a to
82458c2
Compare
ureeves
force-pushed
the
wallet-convert
branch
from
82458c2 to
f55e283
Compare
HDauven
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advertised, this PR introduces two functions in
wallet-coreto be able to convert Dusk between Moonlight and Phoenix. The functions are:moonlight_to_phoenixphoenix_to_moonlightThe tests occur in
ruskin the context of block ingestion, so we're sure that the transactions these two functions create can be ingested properly by the chain.As a consequence, a totally generic
moonlightfunction is created, mirroring thephoenixfunction, that allows for creating a Moonlight transaction in a similar way to Phoenix.