Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonlight wallet support #2320

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Sep 9, 2024

  • Complete moonlight support in the rusk-wallet
  • Extend the cli interface to interact with the network via moonlight

Withdraw rewards from moonlight is not yet added but will be in the future

Extend CLI interface to display moonlight balance
And perform moonlight staking/transfer/unstaking
@Daksh14 Daksh14 changed the base branch from master to mocello/2288_moonlight_wallet September 9, 2024 16:01
@Daksh14 Daksh14 force-pushed the moonlight-wallet-support branch from e0cd235 to 1765e62 Compare September 9, 2024 16:42
@@ -442,9 +485,10 @@ fn confirm(cmd: &Command) -> anyhow::Result<bool> {
println!(" > Recipient = {}", rcvr.preview());
println!(" > Amount to transfer = {} DUSK", amt);
println!(" > Max fee = {} DUSK", Dusk::from(max_fee));
println!(" > ALERT: THIS IS A PUBLIC TRANSACTION");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition ❤️

rusk-wallet/src/wallet.rs Outdated Show resolved Hide resolved
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but may I ask why you moved the tests?

@Daksh14 Daksh14 force-pushed the moonlight-wallet-support branch from 5b2895c to c0e8a79 Compare September 9, 2024 17:00
@moCello moCello linked an issue Sep 9, 2024 that may be closed by this pull request
@Daksh14 Daksh14 force-pushed the moonlight-wallet-support branch from a413b8c to b9cae97 Compare September 9, 2024 18:05
@Daksh14 Daksh14 merged commit 3bab53c into mocello/2288_moonlight_wallet Sep 9, 2024
4 checks passed
@Daksh14 Daksh14 deleted the moonlight-wallet-support branch September 9, 2024 18:06
@Daksh14 Daksh14 restored the moonlight-wallet-support branch September 10, 2024 03:55
@Daksh14 Daksh14 deleted the moonlight-wallet-support branch October 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Moonlight transaction functionalities in rusk-wallet
2 participants