stake-contract: add support for multisig #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
requested review from
autholykos,
fed-franz,
moCello and
ureeves
herr-seppia
force-pushed
the
stake-multisig
branch
from
399814e to
2cf892c
Compare
autholykos
previously approved these changes
Sep 9, 2024
herr-seppia
force-pushed
the
stake-multisig
branch
from
2cf892c to
7c6f3a8
Compare
herr-seppia
force-pushed
the
stake-multisig
branch
3 times, most recently
from
ba4fef9 to
69764d4
Compare
- Change `Stake` to have both funds key and account key - Change `Stake` to use `BlsMultiSignature` - Change `Withdraw` to use `BlsMultiSignature`
Additionally: - change the `reward` and `slash` calls to panic if no stake is found - change `stakes` call to return `StakeKeys` instead of `BlsPublicKey` as key - add `get_stake_keys` call
herr-seppia
force-pushed
the
stake-multisig
branch
from
6f82d63 to
b4bc48f
Compare
|
@ureeves @autholykos I had to add stake-contract: allow to change funds_key when restaking to not lock-in the stake to a specific key |
ureeves
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only keys required to run a node are the so called "provisioner keys"
Basically they are a BLS keypair stored on a node machine.
If the node got compromised, the key pair can be used to move stake funds to a different address
With this PR, instead, the "provisioner keys" would only be used to sign consensus messages.
Indeed, any other operation like "unstake/withdraw" requires to be multisigned with an additional key (aka "funds key") that is enrolled during the "stake" operation
In order to not introduce any breaking change into our wallet, the current execution-core library still has
Stake::newthat takes just a single key, and consider the "funds key" to be the same.Future implementation of execution-core can handle the funds key properly