Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake-contract: fix prev_stake for Stake operation #2299

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

herr-seppia
Copy link
Member

Fix a bug where the previous state were overwritten during a Stake Operation

Even if this had no consequence for the sortition (having None or Some( Stake {amount: None} ) is the same) it was conceptually wrong since it's going to erase the previous state fields like faults, nonce

Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit bb0b836 into master Sep 9, 2024
15 checks passed
@herr-seppia herr-seppia deleted the fix-stake branch September 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants