Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate reward calls into one #2292

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Consolidate reward calls into one #2292

merged 3 commits into from
Sep 6, 2024

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Sep 6, 2024

This is not only a performance optimization, but also useful for minimizing the amount of events emitted - which has a storage impact on prospective archivers.

Eduardo Leegwater Simões added 3 commits September 6, 2024 15:07
Allows for the host to call the stake contract with a vector of `Reward`
to rewards multiple accounts simultaneously.
The call now takes a `Vec<Reward>` and emits all of the rewards
simultaneously as a vector.
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a small suggestion for the comment above reward()

contracts/stake/src/state.rs Show resolved Hide resolved
@ureeves ureeves merged commit 7e52446 into master Sep 6, 2024
15 checks passed
@ureeves ureeves deleted the consolidate-reward branch September 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants