Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor consistency issues #2291

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix minor consistency issues #2291

merged 2 commits into from
Sep 6, 2024

Conversation

Neotamandua
Copy link
Member

This PR addresses two consistency topics:

  1. Every topic in rusk_abi::emit events used in Rusk is lower case and according to ZER0 should be lower case. So I changed the "TREE_LEAF" to "tree_leaf" as it was the only topic that used upper case.
  2. Piecrust has an init method to run arbitrary initialization logic during deployment. For reasons explained in Change constructor to init(ializer) piecrust#381, we have changed all related naming from constructor_ to init_, this change is now also reflected in the relevant Rusk parts.

@Neotamandua Neotamandua merged commit 8d4aaef into master Sep 6, 2024
15 checks passed
@Neotamandua Neotamandua deleted the consistency branch September 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants