Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved deployment pricing #2290

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Improved deployment pricing #2290

merged 3 commits into from
Sep 6, 2024

Conversation

miloszm
Copy link
Contributor

@miloszm miloszm commented Sep 6, 2024

This PR improved deployment pricing in such a way that the cost of deployment should not be negligible to the user.
The deployment charging behaviour is controlled by the following configuration items:

gas_per_deploy_byte
min_deployment_gas_price

Transaction containing deployment will be discarded if the minimum transaction gas price is insufficient.
The defaults are set as follows:

const DEFAULT_GAS_PER_DEPLOY_BYTE: u64 = 100;
const DEFAULT_MIN_DEPLOYMENT_GAS_PRICE: u64 = 2000;

Current defaults should enforce reasonable deployment costs in the real world.

Implements #2207

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miloszm miloszm merged commit ae0b670 into master Sep 6, 2024
15 checks passed
@miloszm miloszm deleted the issue-2207-redux branch September 6, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants