Support contracts sending funds to a Moonlight Account #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
requested review from
miloszm,
autholykos,
fed-franz,
HDauven,
moCello,
marta-belles,
herr-seppia,
Neotamandua,
ZER0 and
Daksh14
Neotamandua
reviewed
Sep 5, 2024
marta-belles
reviewed
Sep 5, 2024
There was a problem hiding this comment.
LGTM, I only left a couple of minor comments.
Although I have a general comment about the tests: if it's not too much trouble, could we add a test that ensures that the code correctly captures scenarios where a transaction should fail? (e.g., attempting to send money from a contract to an account with insufficient funds).
ureeves
force-pushed
the
transfer-to-account
branch
3 times, most recently
from
a1440fe to
30f4dc7
Compare
HDauven
previously approved these changes
Sep 6, 2024
added 3 commits
September 6, 2024 11:13
This structure will be used as an argument to a transfer contract function allowing for a contract to send Dusk to a Moonlight account.
This will allow us to test that the contract successfully transfers funds to an account using the "transfer_to_account" function taking a `TransferToAccount` as argument.
The `transfer_to_account` can be called by contract using the `TransferToAccount` structure to move some of its funds to a Moonlight account.
ureeves
force-pushed
the
transfer-to-account
branch
from
30f4dc7 to
2971fbf
Compare
HDauven
approved these changes
Sep 6, 2024
marta-belles
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the ability of contracts to send funds directly to a Moonlight account. This facilitates use-cases requiring sending Dusk through a contract to Moonlight accounts, including but not limited to bridging.
To achieve this we add a
transfer_to_accountfunction to the transfer contract, taking as argument aTransferToAccountstructure, that can be called by a contract to transfer funds to any Moonlight account they wish. Multiple calls may be chained to make contracts that effectively transfer Dusk to several accounts atomically. The function is the equivalent oftransfer_to_contractbut for accounts, and puts accounts and contracts on the same footing in terms of being able to receive funds directly.One important asymmetry between accounts and contracts, however, is the capability of contracts to reject the funds sent to them by a contract. With this implementation, accounts do not have this capability.