Add transfers between contracts #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello,
herr-seppia and
Neotamandua
moCello
previously approved these changes
Sep 4, 2024
ureeves
force-pushed
the
contract-transfers
branch
from
bdd0c07 to
3d666e1
Compare
added 4 commits
September 4, 2024 16:04
The `TransferToContract` is sent by a sender contract to the transfer contract, signifying the sender's intent to send Dusk to a receiver contract. `ReceiveFromContract` is used by the transfer contract to inform the receiver of the sender and the amount being sent.
The `transfer_to_contract` function can be called by a sender contract to transfer Dusk to a receiver contract. Once called, a function specified by the sender is called on the receiver contract to inform it of the sender's ID and the amount of Dusk sent. The receiver can choose to accept the transfer, by successfully concluding the execution of the function called to inform it, or it can panic and effectively reject the transfer. The `TransferToContract` is used as an argument to the `transfer_to_contract`, and is constructed by the contract calling it. `ReceiveFromContract` is the ata the receiver contract *must* accept for a function to be able to successfully receive funds from another contract. If a contract wished to expose one or more of these functions, it is heavily recommended that they panic if called by anyone else apart from the transfer contract.
ureeves
force-pushed
the
contract-transfers
branch
from
3d666e1 to
635107e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transfers between contracts. It is achieved by adding a new function to the transfer contract -
transfer_to_contract- that is callable by other contracts to signify their intent to transfer Dusk to another contract. Contracts receiving Dusk via this function will then be called using a function specified by the sender contract, and can choose to either accept or reject the transfer based on the data they receive.The basic assumption with this feature is that contracts wishing to transfer Dusk to another contract will be aware of the function the contract uses to receive funds. It is possible to send extra data together with transfer using the
datafield of theTransferToContractstructure, which will be passed to the receiving contract using a field of the same name inReceiveFromContract. This allows for acceptance/rejection of the transfer based on arbitrary data, as opposed to just the sender and amount transferred.