Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk: add protocol version to Message #2251

Merged
merged 10 commits into from
Sep 5, 2024
Merged

rusk: add protocol version to Message #2251

merged 10 commits into from
Sep 5, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Sep 3, 2024 •
edited
Loading

@herr-seppia herr-seppia changed the title rusk: refactor wire messages rusk: add protocol version to Message Sep 3, 2024
@herr-seppia herr-seppia marked this pull request as ready for review September 4, 2024 13:56
fed-franz
fed-franz requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Nice refactoring

I don't get the whole logic behind nonce though. Can you clarify it?

node/src/chain/fsm.rs Outdated Show resolved Hide resolved
@herr-seppia
Copy link
Member Author

@fed-franz why the RFC then?

@fed-franz
Copy link
Contributor

@fed-franz why the RFC then?

Because it's not just a curiosity. It looks strange to me, so I don't want it to be merged without being sure it makes sense

@herr-seppia herr-seppia force-pushed the refactor-pdu branch 2 times, most recently from 113f53f to 9b46b72 Compare September 5, 2024 10:19
fed-franz
fed-franz approved these changes Sep 5, 2024
View reviewed changes
node/src/network.rs Show resolved Hide resolved
@herr-seppia herr-seppia merged commit 134bf87 into master Sep 5, 2024
15 checks passed
@herr-seppia herr-seppia deleted the refactor-pdu branch September 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fed-franz fed-franz fed-franz approved these changes

@moCello moCello Awaiting requested review from moCello

@ureeves ureeves Awaiting requested review from ureeves

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Rusk Versioning
2 participants
@herr-seppia @fed-franz