Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution-core: re-export and type alias poseidon merkle types #2248

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Sep 3, 2024

By reexporting we can wrap another dusk-dependency (poseidon-merkle) downstream and the type alias highly increase the readability of the code.

Additionally the NoteLeaf can replace the EnrichedNote in wallet-core (see #2241)

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks way better. LGTM.

@moCello moCello merged commit a7fa425 into master Sep 4, 2024
15 checks passed
@moCello moCello deleted the mocello/poseidon-merkle branch September 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants