wallet-core: Remove u64 cast when generating the seed

[moCello]

Resolves #2209

[moCello]

Note: Since this is a very breaking change, please only merge with explicit approval by all involved parties.

[herr-seppia]

As previously discussed, I am against this change because people would not be able to use the same seed used during ITN (and therefore they would not be able to claim their rewards)

I'm curious to know what's the benefit of this (apart from code clarity)

I'll put a "conservative" RFC while waiting for someone that change my mind

[HDauven]

As previously discussed, I am against this change because people would not be able to use the same seed used during ITN (and therefore they would not be able to claim their rewards)

I'm curious to know what's the benefit of this (apart from code clarity)

I'll put a "conservative" RFC while waiting for someone that change my mind

Why can't we create a claim contract, whereby they sign they're the owner for a given key, but get the funds on a newly generated key?

We would need to put in some extra work and still have the old way of generating keys available in some library, but it's not like it would be impossible to do this, right?

[herr-seppia]

whereby they sign they're the owner for a given key,

And how could they prove it if they are not able to derive the old secret key anymore?

[autholykos]

Closing as we no longer need to change key generation