node: Implement a FSM for stalled_chain states #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 27, 2024 16:48
fed-franz
requested changes
Sep 8, 2024
- Revert to prev_state_hash commit. - Blacklist the blk from non-main branch - Read final block from DB
fed-franz
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2245
Basically, the concept is the following:
If a node is continuously receiving future blocks but the local tip does not change for more than 60sec we assume that it's stalled (State::Stalled). If so, it asks the network for missing blocks.
Once the node receives all blocks from local_final until local_tip, it tries to detect at what height/block is the fork and eventually it verifies the new block.
If the verification passes, the node is in
State::StalledOnForkstate. If so, it reverts to the previous state_root and tries to accept the new block.