Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-wallet: Add allocation page #2202

Merged
merged 1 commit into from
Aug 31, 2024
Merged

web-wallet: Add allocation page #2202

merged 1 commit into from
Aug 31, 2024

Conversation

kieranhall
Copy link
Member

@kieranhall kieranhall commented Aug 24, 2024 •
edited
Loading

Resolves #2196

@kieranhall kieranhall self-assigned this Aug 27, 2024
@kieranhall
Copy link
Member Author

Please note the following:

  • The allocation page is behind the feature flag VITE_CONTRACT_ALLOCATE_DISABLED which is set to true in the README.
  • AllocateContract.svelte passes currentAddress and balance.maximum to Allocate.svelte's unshieldedAddress and unshieldedBalance right now because the staking account (which will serve as the unshieldedAddress is not exposed by dusk-wallet-js (yet).

@kieranhall kieranhall marked this pull request as ready for review August 27, 2024 09:29
ascartabelli
ascartabelli requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some minor comments.

What I think is missing here are tests: for the function that have been isolated, for components, and for +page files too where, for example, is quite important that the updateOperation("") happens onDestroy.

Good to merge otherwise.

web-wallet/src/lib/components/Allocate/Allocate.svelte Show resolved Hide resolved
web-wallet/src/lib/components/Allocate/Allocate.svelte Outdated Show resolved Hide resolved
web-wallet/src/lib/components/GasFee/GasFee.svelte Outdated Show resolved Hide resolved
web-wallet/src/routes/(app)/dashboard/+page.svelte Show resolved Hide resolved
@kieranhall kieranhall mentioned this pull request Aug 27, 2024
Open
@kieranhall kieranhall force-pushed the feature-2196 branch 3 times, most recently from 52e2006 to 7b57f18 Compare August 30, 2024 08:29
@kieranhall kieranhall force-pushed the feature-2196 branch 2 times, most recently from 2f2c2c0 to a9a1094 Compare August 30, 2024 09:59
@kieranhall kieranhall force-pushed the feature-2196 branch 5 times, most recently from caf4c53 to 4b4f79f Compare August 30, 2024 21:48
@kieranhall kieranhall merged commit d889a9c into master Aug 31, 2024
15 checks passed
@kieranhall kieranhall deleted the feature-2196 branch August 31, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascartabelli ascartabelli ascartabelli approved these changes

@nortonandreev nortonandreev Awaiting requested review from nortonandreev

@deuch13 deuch13 Awaiting requested review from deuch13

Assignees

@kieranhall kieranhall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Shield / Unshield page
2 participants
@kieranhall @ascartabelli