Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: Fix Average Fee Paid label #2195

Merged
merged 1 commit into from
Aug 23, 2024
Merged

explorer: Fix Average Fee Paid label #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions explorer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fix Average Fee Paid label [#2057]
- Fix list items alignment on mobile [#2056]

## [0.1.0] - 2024-07-24
Expand All @@ -42,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#2037]: https://github.com/dusk-network/rusk/issues/2037
[#2039]: https://github.com/dusk-network/rusk/issues/2039
[#2056]: https://github.com/dusk-network/rusk/issues/2056
[#2057]: https://github.com/dusk-network/rusk/issues/2057
[#2059]: https://github.com/dusk-network/rusk/issues/2059
[#2061]: https://github.com/dusk-network/rusk/issues/2061
[#2159]: https://github.com/dusk-network/rusk/issues/2159
Expand Down
4 changes: 2 additions & 2 deletions explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ exports[`Block Details > renders the Block Details component 1`] = `
class="dusk-icon dusk-icon--size--normal detail-list__help"
data-tooltip-id="main-tooltip"
data-tooltip-place="top"
data-tooltip-text="The average fee paid for the transactions within the block"
data-tooltip-text="The average gas price for the transactions within the block"
data-tooltip-type="info"
role="graphics-symbol"
viewBox="0 0 24 24"
Expand All @@ -310,7 +310,7 @@ exports[`Block Details > renders the Block Details component 1`] = `
</svg>


average fee paid
average gas price
</dt>

<dd
Expand Down
2 changes: 1 addition & 1 deletion explorer/src/lib/components/__tests__/__snapshots__/BlocksList.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`Blocks List > renders the Blocks List component 1`] = `
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down
6 changes: 3 additions & 3 deletions explorer/src/lib/components/block-details/BlockDetails.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,11 @@
</svelte:fragment>
</ListItem>

<!-- AVERAGE FEE PAID -->
<!-- AVERAGE GAS PRICE -->
<ListItem
tooltipText="The average fee paid for the transactions within the block"
tooltipText="The average gas price for the transactions within the block"
>
<svelte:fragment slot="term">average fee paid</svelte:fragment>
<svelte:fragment slot="term">average gas price</svelte:fragment>
<svelte:fragment slot="definition"
>{formatter(luxToDusk(data.transactions.stats.averageGasPrice))} DUSK</svelte:fragment
>
Expand Down
6 changes: 3 additions & 3 deletions explorer/src/lib/components/blocks-list/BlocksList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@
/>
</ListItem>

<!-- AVERAGE FEE PAID -->
<!-- AVERAGE GAS PRICE -->
<ListItem
tooltipText={displayTooltips
? "The average fee paid for the transactions within the block"
? "The average gas price for the transactions within the block"
: ""}
>
<svelte:fragment slot="term">average fee paid</svelte:fragment>
<svelte:fragment slot="term">average gas price</svelte:fragment>
<svelte:fragment slot="definition">
{formatter(luxToDusk(data.transactions.stats.averageGasPrice))} DUSK
</svelte:fragment>
Expand Down
30 changes: 15 additions & 15 deletions explorer/src/routes/blocks/__tests__/__snapshots__/page.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -184,7 +184,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -288,7 +288,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -392,7 +392,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -496,7 +496,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -600,7 +600,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -704,7 +704,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -808,7 +808,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -912,7 +912,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1016,7 +1016,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1120,7 +1120,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1224,7 +1224,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1328,7 +1328,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1432,7 +1432,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -1536,7 +1536,7 @@ exports[`Blocks page > should render the Blocks page with the mobile layout 1`]
class="details-list__term details-list__term--table"
>

average fee paid
average gas price
</dt>

<dd
Expand Down
8 changes: 4 additions & 4 deletions explorer/src/routes/blocks/block/__tests__/__snapshots__/page.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ exports[`Block Details > should render the Block Details page and query the nece
class="dusk-icon dusk-icon--size--normal detail-list__help"
data-tooltip-id="main-tooltip"
data-tooltip-place="top"
data-tooltip-text="The average fee paid for the transactions within the block"
data-tooltip-text="The average gas price for the transactions within the block"
data-tooltip-type="info"
role="graphics-symbol"
viewBox="0 0 24 24"
Expand All @@ -388,7 +388,7 @@ exports[`Block Details > should render the Block Details page and query the nece
</svg>


average fee paid
average gas price
</dt>

<dd
Expand Down Expand Up @@ -978,7 +978,7 @@ exports[`Block Details > should render the Transaction section of the Block Deta
class="dusk-icon dusk-icon--size--normal detail-list__help"
data-tooltip-id="main-tooltip"
data-tooltip-place="top"
data-tooltip-text="The average fee paid for the transactions within the block"
data-tooltip-text="The average gas price for the transactions within the block"
data-tooltip-type="info"
role="graphics-symbol"
viewBox="0 0 24 24"
Expand All @@ -989,7 +989,7 @@ exports[`Block Details > should render the Transaction section of the Block Deta
</svg>


average fee paid
average gas price
</dt>

<dd
Expand Down
Loading