Remove unused definitions #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fed-franz
force-pushed
the
2188-unused-definitions
branch
2 times, most recently
from
25465c9 to
29ea5b3
Compare
fed-franz
force-pushed
the
2188-unused-definitions
branch
from
29ea5b3 to
576d2c3
Compare
herr-seppia
requested changes
Aug 26, 2024
fed-franz
force-pushed
the
2188-unused-definitions
branch
from
576d2c3 to
36bdfef
Compare
herr-seppia
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2188
Remove
remove_msgs_greater_thanRemove
delete_candidate_blocksCONSENSUS_DELAY_MSwas already removedaddis currently usedcollect_from_pastis not removed (because part of a trait), but it's not invoked anymore