Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Refactor dashboard to use routes #2164

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

kieranhall
Copy link
Member

Resolves #2075

@kieranhall kieranhall added the module:web-wallet Issues related to web-wallet module label Aug 20, 2024
@kieranhall kieranhall self-assigned this Aug 20, 2024
@kieranhall kieranhall force-pushed the feature-2075 branch 2 times, most recently from c7f0829 to 4fa207f Compare August 20, 2024 14:28
@nortonandreev
Copy link
Contributor

Seems like the Card component that was holding the main content is missing:

Screenshot 2024-08-20 at 19 45 18

Also, looking at the design, Transact is split into Send and Receive. Was there a decision made to keep them both together? I guess having Send and Receive separately is better in a sense that Receive is easy to find, however, I also would get the argument for having them both under one section that is about transacting. 🤷‍♂️

Screenshot 2024-08-20 at 19 50 44

@nortonandreev
Copy link
Contributor

Another minor thing I noticed: we have transact tab vs transfer path and stake tab vs staking path. Should we unify them?

@kieranhall
Copy link
Member Author

kieranhall commented Aug 22, 2024

Seems like the Card component that was holding the main content is missing:

I've added the Card into this PR now and made adjustments to the Card in accordance with the updates in Figma.

Also, looking at the design, Transact is split into Send and Receive. Was there a decision made to keep them both together? I guess having Send and Receive separately is better in a sense that Receive is easy to find, however, I also would get the argument for having them both under one section that is about transacting. 🤷‍♂️

#2175

Another minor thing I noticed: we have transact tab vs transfer path and stake tab vs staking path. Should we unify them?

We might as well make any changes in #2175 too, as /transfer will be removed anyway.

@nortonandreev
Copy link
Contributor

Screenshot 2024-08-23 at 17 06 40 Screenshot 2024-08-23 at 17 05 59

The gap after the holdings container in the transact is too small (ie. the buttons have bigger spacing in between – we should instead have bigger spacing between the container above and the buttons, as spacing is used for grouping similar elements).

Also the spacing after the holding container in the transact and the stake views is different (1em vs 0.625em).

@kieranhall kieranhall merged commit 46594e0 into master Aug 23, 2024
16 checks passed
@kieranhall kieranhall deleted the feature-2075 branch August 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:web-wallet Issues related to web-wallet module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet: Update Dashboard screen to use DashboardNav navigation
2 participants