Move rusk-wallet to rusk monorepo #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daksh14
changed the title
Daksh14
force-pushed
the
move-wallet-cli-to-rusk
branch
3 times, most recently
from
33fd964 to
d045c52
Compare
Add dispatch binary building and basic CI tests
Daksh14
force-pushed
the
move-wallet-cli-to-rusk
branch
from
d045c52 to
6bf3f77
Compare
Daksh14
force-pushed
the
move-wallet-cli-to-rusk
branch
from
81251cc to
fa8ee9c
Compare
|
Please remember to adapt our dusk-deployer in order to download the wallet from the new repo |
Added an issue here: https://github.com/dusk-network/dusk-deployer/issues/65 |
HDauven
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM
Like @herr-seppia said, we need to make sure we update after merging:
- https://github.com/dusk-network/dusk-deployer/issues/65
- Update Rusk-wallet download location node-installer#85
Furthermore, we need to:
- Test that the binary building still works as expected.
- Make sure the Rusk CI only got triggered now because of the toolchain and/or Cargo.toml change.
herr-seppia
reviewed
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2141