Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Limit transactions & faults in proposed block #2140

Merged
merged 6 commits into from
Sep 7, 2024
Merged

Conversation

goshawk-3
Copy link
Contributor

fixes #2122

@goshawk-3 goshawk-3 marked this pull request as ready for review August 16, 2024 13:31
@goshawk-3 goshawk-3 marked this pull request as draft August 19, 2024 07:03
@fed-franz fed-franz marked this pull request as ready for review September 6, 2024 10:47
Copy link
Contributor Author

@goshawk-3 goshawk-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change generate_block in order to not include more txs than allowed

ps: and filter the faults vec taking no more than allowed (possibly giving priority to older faults)

Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fed-franz fed-franz merged commit 004e58e into master Sep 7, 2024
15 checks passed
@fed-franz fed-franz deleted the fix-2122 branch September 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit transactions & faults in proposed block
3 participants